Fixes #20 Filter subpaths #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/var/www/html/src/Filters/QueryMatchFilter.php:67 Undefined array key 0
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
============================================
+ Coverage 89.36% 89.47% +0.10%
- Complexity 202 209 +7
============================================
Files 11 11
Lines 395 399 +4
============================================
+ Hits 353 357 +4
Misses 42 42 ☔ View full report in Codecov by Sentry. |
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It is naive implementation to fix #20
And because the QueryTest doesn't fail if a test fails, I added a baseline for the currently failing tests, so we can run them normally and make sure, if one test fails in the future we know.
Test Plan
I used the QueryTest for subpaths.
Related PRs and Issues
#20